Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmsquic 2.4.5 (new formula) #192082

Merged
merged 2 commits into from
Nov 2, 2024
Merged

libmsquic 2.4.5 (new formula) #192082

merged 2 commits into from
Nov 2, 2024

Conversation

liveans
Copy link
Contributor

@liveans liveans commented Sep 27, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Sep 27, 2024
@liveans liveans changed the title libmsquic 2.4.4 libmsquic 2.4.4 (new formula) Sep 27, 2024
@liveans
Copy link
Contributor Author

liveans commented Sep 27, 2024

First time contributing into this repo, please let me know if I'm doing something wrong or missing anything obvious. Thanks!

@liveans liveans marked this pull request as ready for review September 27, 2024 09:49
Formula/lib/libmsquic.rb Outdated Show resolved Hide resolved
Formula/lib/libmsquic.rb Outdated Show resolved Hide resolved
Formula/lib/libmsquic.rb Outdated Show resolved Hide resolved
Formula/lib/libmsquic.rb Outdated Show resolved Hide resolved
@liveans liveans force-pushed the add_libmsquic branch 2 times, most recently from 9fb91b6 to dfc99b9 Compare September 27, 2024 12:42
@liveans
Copy link
Contributor Author

liveans commented Sep 29, 2024

Gentle reminder on this @carlocab, sorry if it bothers. Looking for a guidance here according to the repo rules.

@liveans liveans changed the title libmsquic 2.4.4 (new formula) libmsquic 2.4.5 (new formula) Oct 2, 2024
@liveans
Copy link
Contributor Author

liveans commented Oct 7, 2024

Hello @carlocab, I know that you're busy and there are couple of things going on, but I'd like to ping on this one more time, if there is anything can be done from my side, I can do it. We can even hop on a call to discuss things, if it's possible. Are there any rough estimates for this to get reviewed again, like 1 week, month?

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Oct 26, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this fell off my radar -- I get too many GitHub notifications. Thanks for the contribution!

@carlocab carlocab added this pull request to the merge queue Nov 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 2, 2024
@liveans
Copy link
Contributor Author

liveans commented Nov 2, 2024

It says that, there are missing bottles, are there anything I should do about it?

@carlocab
Copy link
Member

carlocab commented Nov 2, 2024

No, automation will take care of it -- it's just a bit slow.

Copy link
Contributor

github-actions bot commented Nov 2, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 2, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 2, 2024
@carlocab carlocab removed this pull request from the merge queue due to a manual request Nov 2, 2024
@carlocab carlocab added this pull request to the merge queue Nov 2, 2024
@carlocab
Copy link
Member

carlocab commented Nov 2, 2024

CI seems to keep getting stuck at pulling Docker containers for some reason.

@carlocab carlocab removed this pull request from the merge queue due to a manual request Nov 2, 2024
@carlocab carlocab added this pull request to the merge queue Nov 2, 2024
@liveans
Copy link
Contributor Author

liveans commented Nov 2, 2024

It also took a while to pull containers in PR CI as well.

@carlocab carlocab removed this pull request from the merge queue due to a manual request Nov 2, 2024
@carlocab carlocab added this pull request to the merge queue Nov 2, 2024
Merged via the queue into Homebrew:master with commit 21efbea Nov 2, 2024
15 checks passed
@liveans
Copy link
Contributor Author

liveans commented Nov 3, 2024

Thanks for merging this @carlocab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants