Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import macro-generated UInt gadgets from arkworks #149

Open
DanieleDiBenedetto opened this issue Dec 22, 2021 · 0 comments
Open

Import macro-generated UInt gadgets from arkworks #149

DanieleDiBenedetto opened this issue Dec 22, 2021 · 0 comments
Assignees
Labels
new feature nice to have Possible new feature to introduce sw design SW design choice to be made or implemented

Comments

@DanieleDiBenedetto
Copy link
Collaborator

arkworks generates the UInt gadget (from Uint16 up to UInt128) using macros (as the code is basically the same):

https://github.com/arkworks-rs/r1cs-std/blob/master/src/bits/uint.rs

Let us adopt the same procedure, and let's define and implement for them also AllocGadget, ToBitsGadget and FromBitsGadget
(currently these functions already exist, but they are not put in what would be the correct corresponding trait, making the calling code a bit confusional and not standard in terms of traits to be used).
Let's implement this traits (if not already) also for UInt8 and Boolean gadgets (that must be excluded, like arkworks, from the macro generation procedure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature nice to have Possible new feature to introduce sw design SW design choice to be made or implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants