Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp naming conventions: totp_timestamp vs last_otp_at #121

Open
rmm5t opened this issue May 2, 2017 · 0 comments
Open

Timestamp naming conventions: totp_timestamp vs last_otp_at #121

rmm5t opened this issue May 2, 2017 · 0 comments

Comments

@rmm5t
Copy link
Contributor

rmm5t commented May 2, 2017

I'd like to suggest a more consistent naming convention to replace the new totp_timestamp column in preparation for v2.0. A better name would be something like last_otp_at. This would better match Rails naming conventions, it would better coincide with direct_otp_sent_at, and this would match rotp's recommendation.

I'm happy to provide a pull-request for this, but I'd like to get some sense that it's likely to be accepted first and/or if it interests others that use this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant