Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fog component to the environment settings #69

Open
keianhzo opened this issue May 18, 2022 · 2 comments
Open

Move fog component to the environment settings #69

keianhzo opened this issue May 18, 2022 · 2 comments
Assignees
Labels
Backlog P2 Address when able

Comments

@keianhzo
Copy link
Contributor

After the latest AFrame refactor fog is now part of the environment settings. We need to refactor this otherwise all the scenes exported from Blender with fog will be broken.

Related Hubs-Foundation/hubs#5438

@keianhzo keianhzo self-assigned this May 18, 2022
@netpro2k
Copy link
Contributor

Note that the current fog component is still working in Hubs its just being handled differently than before. Since we removed the fog component from aframe I merged it into environment-settings on the Hubs side but still not sure that is the best thing to do. I was looking to fix the regression quickly and this decision doesn't bind us to any changes since the external API didn't change yet. I think its probably correct to bundle it into environment-settings but we should think about it a bit more.

@keianhzo
Copy link
Contributor Author

Oh yep, that's true. There is no urgency then in moving this to the environment settings

@keianhzo keianhzo added the P2 Address when able label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog P2 Address when able
Projects
None yet
Development

No branches or pull requests

2 participants