Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video-texture-target is darkened since THREE 141 update #5599

Closed
netpro2k opened this issue Jul 20, 2022 · 1 comment · Fixed by #5604 or #5615
Closed

video-texture-target is darkened since THREE 141 update #5599

netpro2k opened this issue Jul 20, 2022 · 1 comment · Fixed by #5604 or #5615
Labels
bug needs triage For bugs that have not yet been assigned a fix priority

Comments

@netpro2k
Copy link
Contributor

Description
Similar to #5571 video-texture-targets are also darkened.

Screenshots
image

Additional context
The fix we applied for camera tool isn't quite as easy to apply here since onBeforeRender has to be applied to each object that might have the video-texture-target material on it. Conceptually video-texture-target is a "material component" so it should apply to all objects using that material. In practice we can't actually add aframe components to materials, only objects, so it might be ok to just do the same trick and set onBeforeRender up on the mesh we grab the material from in video-texture-target.

@netpro2k netpro2k added bug needs triage For bugs that have not yet been assigned a fix priority labels Jul 20, 2022
@takahirox
Copy link
Contributor

Three.js has a material.onBeforeRender hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage For bugs that have not yet been assigned a fix priority
Projects
None yet
2 participants