Revert scene grabbables support #6515
Merged
+141
−495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts "Merge pull request #6487 from mozilla/scene-grabbables". This reverts commit 4324d10, reversing changes made to 746413d. This fixes the following GitHub bugs: Spacebar Menu Scale and Rotate Buttons Do Nothing When Interacted With #6496 Physics doesn't work when in-room objects are thrown #6503 Physics doesn't continue working after moving an object that has had physics permanently enabled on it #6504 The spacebar menu doesn't show up for objects which have been dropped in the room from a file browser #6505 This reverts the changes from the following commits: c23b7d4 Add warning for negative scale when creating interactables bounds ae050ee Revert media collision mask ec12e4c Scene grabbables support
Exairnous
force-pushed
the
revert-scene-grabbables-support
branch
from
1e2e5bb to
0dabc28
Compare
|
I concur that this is the least-bad option at this point. |
|
Thanks @DougReeder. I've Merged it, now. |
This was referenced Nov 19, 2024
Exairnous
added a commit
to Hubs-Foundation/blender-gltf-behavior-graph
that referenced
this pull request
Nov 26, 2024
Scene grabbables support was reverted (Hubs-Foundation/hubs#6515) in the Hubs client due to bugs and is now only present for the Hubs Client's addons branch and its behavior graphs add-on. This commit restores the scene grabbables and physics support (along with fixes/improvements that were added to it in the main Blender add-on) to the behavior graphs Blender add-on to allow the functionality to be used with the Hubs Client's addons branch and its behavior graphs add-on. A corresponding commit to the main Blender add-on removes support for scene grabbables/physics in the main Blender add-on so it maintains compatibility with the current Hubs Client.
This was referenced Nov 26, 2024
Exairnous
added a commit
to Hubs-Foundation/hubs-blender-exporter
that referenced
this pull request
Nov 26, 2024
Scene grabbables support was reverted (Hubs-Foundation/hubs#6515) in the Hubs client due to bugs and is now only present for the Hubs Client's addons branch and its behavior graphs add-on. This commit removes the scene grabbables and physics support from the main Blender add-on to maintain compatibility with the current Hubs Client. A corresponding commit to the behavior graphs Blender add-on adds support for scene grabbables/physics back into the behavior graphs Blender add-on so that the functionality isn't lost and can be used there. Reverts "Merge pull request #285 from MozillaReality/fix-import-error-reporting" This reverts commit 7eb5656, reversing changes made to 87074ec. Reverts "Merge pull request #282 from MozillaReality/scene-grabbables" This reverts commit 87074ec, reversing changes made to 3712349.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #6487 and fixes these bugs caused by it: