Skip to content

Commit cf8fe2c

Browse files
fix: BROS-483: User able to delete vector regions from View All mode (#8647)
Co-authored-by: nick-skriabin <[email protected]>
1 parent 1b188d7 commit cf8fe2c

File tree

1 file changed

+1
-21
lines changed

1 file changed

+1
-21
lines changed

web/libs/editor/src/regions/VectorRegion.jsx

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -187,30 +187,15 @@ const Model = types
187187
self.mouseOverStartPoint = value;
188188
},
189189

190-
addPoint() {
191-
// KonvaVector managing vector points internally.
192-
// This method is just a fallback for compatibility
193-
},
194-
195190
setDrawing(drawing) {
196191
self.isDrawing = drawing;
197192
},
198193

199-
checkSizes() {
200-
// This method is called after creation to ensure proper sizing
201-
// For vector regions, we don't need to do anything special here
202-
},
203-
204194
closePoly() {
205195
if (!self.closable) return;
206196
self.vectorRef.close();
207197
},
208198

209-
notifyDrawingFinished() {
210-
// This method is called when drawing is finished
211-
// For vector regions, we don't need to do anything special here
212-
},
213-
214199
onSelection(type) {
215200
if (type === "reset") {
216201
self.vectorRef.clearSelection();
@@ -443,12 +428,6 @@ const Model = types
443428
self.closed = isClosed;
444429
},
445430

446-
// Method to handle selection changes from the Selection tool
447-
onSelectionChange() {
448-
// This method can be called when the Selection tool changes selection state
449-
// We can add any custom logic here if needed
450-
},
451-
452431
setKonvaVectorRef(ref) {
453432
self.vectorRef = ref;
454433
},
@@ -538,6 +517,7 @@ const HtxVectorView = observer(({ item, suggestion }) => {
538517
return;
539518
}
540519
// Handle region selection
520+
if (item.isReadOnly()) return;
541521
if (item.parent.getSkipInteractions()) return;
542522
if (item.isDrawing) return;
543523
if (e.evt.altKey || e.evt.ctrlKey || e.evt.shiftKey || e.evt.metaKey) return;

0 commit comments

Comments
 (0)