Port waybar weather module pr from hyprdots #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We should further look into this. 2 external dependencies are too much IMO. Let's hold this PR for a while. |
Contributor
Author
|
@kRHYME7 only one of them is actually used atm (python-requests), but in the original pr it was recommended to use the other, the script just hasn't been updated to include that yet. |
Contributor
|
@boulder-roller Will merge this now. But there will be changes Also, I think I should rename the "custom_hypr.lst : and "custom_app.lst ", it's confusing. renaming it into pkg_custom.lst and pkg_core.lst |
seyfu-t
pushed a commit
to seyfu-t/HyDE
that referenced
this pull request
Mar 10, 2025
Port of prasanthrangan/hyprdots#1818 ## Type of change - [ ] **Bug fix** (non-breaking change which fixes an issue) - [x] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [ ] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of prasanthrangan/hyprdots#1192
Type of change