Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap callback parameters for SocketRouter #31

Open
I3uckwheat opened this issue Dec 30, 2020 · 0 comments
Open

Swap callback parameters for SocketRouter #31

I3uckwheat opened this issue Dec 30, 2020 · 0 comments
Labels
backend lives within the /backend directory low priority refactor something needs to be coded differently

Comments

@I3uckwheat
Copy link
Owner

https://github.com/I3uckwheat/cards-of-carousal/blob/main/backend/app/socket.js#L19

Instead of using (req, webSocket), we should flip it to use (webSocket, req) like the wss connection's callback.
@I3uckwheat I3uckwheat added backend lives within the /backend directory refactor something needs to be coded differently labels Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend lives within the /backend directory low priority refactor something needs to be coded differently
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@I3uckwheat