We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent 2f5cd37 commit 004ceebCopy full SHA for 004ceeb
src/segment_evaluation/mod.rs
@@ -141,8 +141,6 @@ fn check_operator(
141
// TODO: Go implementation also compares strings (by parsing them as floats). Do we need this?
142
// https://github.com/IBM/appconfiguration-go-sdk/blob/master/lib/internal/models/Rule.go#L82
143
// TODO: we could have numbers not representable as f64, maybe we should try to parse it to i64 and u64 too?
144
- // TODO: we should have a different nesting style here: match the reference_value first and error out when given
145
- // entity attr does not match. This would yield more natural error messages
146
AttrValue::Numeric(data) => Ok(*data > reference_value.parse()?),
147
_ => Err(CheckOperatorErrorDetail::EntityAttrNotANumber),
148
},
0 commit comments