Skip to content

Commit 004ceeb

Browse files
jgsogorainerschoe
andauthored
Update src/segment_evaluation/mod.rs
Co-authored-by: Rainer Schoenberger <[email protected]> Signed-off-by: Javier G. Sogo <[email protected]>
1 parent 2f5cd37 commit 004ceeb

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/segment_evaluation/mod.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,6 @@ fn check_operator(
141141
// TODO: Go implementation also compares strings (by parsing them as floats). Do we need this?
142142
// https://github.com/IBM/appconfiguration-go-sdk/blob/master/lib/internal/models/Rule.go#L82
143143
// TODO: we could have numbers not representable as f64, maybe we should try to parse it to i64 and u64 too?
144-
// TODO: we should have a different nesting style here: match the reference_value first and error out when given
145-
// entity attr does not match. This would yield more natural error messages
146144
AttrValue::Numeric(data) => Ok(*data > reference_value.parse()?),
147145
_ => Err(CheckOperatorErrorDetail::EntityAttrNotANumber),
148146
},

0 commit comments

Comments
 (0)