Skip to content

Commit 7124dbd

Browse files
authored
fix(helm): add missing metrics configuration to values.schema.json (#1382)
PR #1313 added metrics configuration to values.yaml but did not update values.schema.json, causing helm template validation to fail with: 'Additional property metrics is not allowed' This commit adds the metrics property definition to the schema including: - enabled: boolean to toggle metrics collection - port: integer for metrics endpoint port - serviceMonitor: object for Prometheus Operator integration - customLabels: object for custom metric labels Fixes schema validation error introduced in PR #1313 Related to Feature #218 (Prometheus Metrics Instrumentation) Signed-off-by: ppippi-dev <[email protected]>
1 parent 91e0f01 commit 7124dbd

File tree

1 file changed

+39
-0
lines changed

1 file changed

+39
-0
lines changed

charts/mcp-stack/values.schema.json

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,45 @@
132132
"maximum": 65535,
133133
"default": 4444
134134
},
135+
"metrics": {
136+
"type": "object",
137+
"description": "Metrics configuration",
138+
"properties": {
139+
"enabled": {
140+
"type": "boolean",
141+
"description": "Enable metrics collection",
142+
"default": true
143+
},
144+
"port": {
145+
"type": "integer",
146+
"description": "Metrics port",
147+
"minimum": 1,
148+
"maximum": 65535,
149+
"default": 8000
150+
},
151+
"serviceMonitor": {
152+
"type": "object",
153+
"description": "ServiceMonitor configuration for Prometheus Operator",
154+
"properties": {
155+
"enabled": {
156+
"type": "boolean",
157+
"description": "Enable ServiceMonitor creation",
158+
"default": true
159+
}
160+
},
161+
"additionalProperties": false
162+
},
163+
"customLabels": {
164+
"type": "object",
165+
"description": "Custom labels for metrics",
166+
"additionalProperties": {
167+
"type": "string"
168+
},
169+
"default": {}
170+
}
171+
},
172+
"additionalProperties": false
173+
},
135174
"probes": {
136175
"type": "object",
137176
"description": "Health probe configuration",

0 commit comments

Comments
 (0)