Skip to content

Commit b54ce35

Browse files
committed
fix: resolve pylint issues - import order and MessageToDict parameter
- Fix import order in bootstrap_db.py: move sqlalchemy before alembic - Replace invalid 'always_print_fields_with_no_presence' parameter with 'including_default_value_fields' in translate_grpc.py - Parameter was removed/renamed in protobuf >=6.33.0 Pylint now passes with 10.00/10 rating. All tests continue to pass (3624 passed, 87 skipped). Signed-off-by: Mihai Criveti <[email protected]>
1 parent 1adfa1f commit b54ce35

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

.pylintrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ int-import-graph=
387387
known-standard-library=
388388

389389
# Force import order to recognize a module as part of a third party library.
390-
known-third-party=enchant
390+
known-third-party=enchant,alembic
391391

392392
# Couples of modules and preferred modules, separated by a comma.
393393
preferred-modules=

mcpgateway/bootstrap_db.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,10 @@
3535
from typing import Any, cast
3636

3737
# Third-Party
38+
from sqlalchemy import create_engine, inspect
39+
3840
from alembic import command
3941
from alembic.config import Config
40-
from sqlalchemy import create_engine, inspect
4142

4243
# First-Party
4344
from mcpgateway.config import settings

mcpgateway/translate_grpc.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ async def invoke(
278278
)
279279

280280
# Convert protobuf response to JSON
281-
response_dict = json_format.MessageToDict(response_msg, preserving_proto_field_name=True, always_print_fields_with_no_presence=True)
281+
response_dict = json_format.MessageToDict(response_msg, preserving_proto_field_name=True, including_default_value_fields=True)
282282

283283
logger.debug(f"Successfully invoked {service}.{method}")
284284
return response_dict
@@ -350,7 +350,7 @@ async def invoke_streaming(
350350
# Yield responses as they arrive
351351
try:
352352
for response_msg in stream_call:
353-
response_dict = json_format.MessageToDict(response_msg, preserving_proto_field_name=True, always_print_fields_with_no_presence=True)
353+
response_dict = json_format.MessageToDict(response_msg, preserving_proto_field_name=True, including_default_value_fields=True)
354354
yield response_dict
355355
except grpc.RpcError as e:
356356
logger.error(f"Streaming RPC error: {e}")

0 commit comments

Comments
 (0)