Skip to content

Commit edd393d

Browse files
committed
fix: improve plugin config chart implementation
- Add newline at end of configmap-gateway-plugin.yaml - Improve schema descriptions for pluginConfig - Restore ingress annotations field (as empty object) - Fix volumeMounts indentation in deployment - Ensure backward compatibility with existing deployments Signed-off-by: Mihai Criveti <[email protected]>
1 parent 452f612 commit edd393d

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

charts/mcp-stack/templates/configmap-gateway-plugin.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ metadata:
99
data:
1010
config.yaml: |
1111
{{- .Values.mcpContextForge.pluginConfig.plugins | nindent 4 }}
12-
{{- end }}
12+
{{- end }}

charts/mcp-stack/templates/deployment-mcpgateway.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,12 +152,13 @@ spec:
152152
# Resource requests / limits
153153
resources:
154154
{{- toYaml .Values.mcpContextForge.resources | nindent 12 }}
155+
155156
{{- /* Plugins enabled need the plugins configuration */}}
156157
{{- if .Values.mcpContextForge.pluginConfig.enabled }}
157158
volumeMounts:
158-
- name: plugin-config-volume
159-
mountPath: /app/{{ .Values.mcpContextForge.config.PLUGIN_CONFIG_FILE }}
160-
subPath: config.yaml
159+
- name: plugin-config-volume
160+
mountPath: /app/{{ .Values.mcpContextForge.config.PLUGIN_CONFIG_FILE }}
161+
subPath: config.yaml
161162
{{- end }}
162163
{{- if .Values.mcpContextForge.pluginConfig.enabled }}
163164
volumes:

charts/mcp-stack/values.schema.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -254,16 +254,16 @@
254254

255255
"pluginConfig": {
256256
"type": "object",
257-
"description": "Content of the plugin file",
257+
"description": "Plugin configuration via ConfigMap",
258258
"properties": {
259259
"enabled": {
260260
"type": "boolean",
261-
"description": "Enable pluginConfig loading for ingress",
261+
"description": "Enable plugin configuration loading via ConfigMap",
262262
"default": false
263263
},
264264
"plugins": {
265265
"type": "string",
266-
"description": "contents of plugin file"
266+
"description": "Plugin configuration file contents (YAML)"
267267
}
268268
}
269269
},

charts/mcp-stack/values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,9 @@ mcpContextForge:
9999
host: gateway.local # CHANGE to your FQDN (e.g. api.example.com)
100100
path: /
101101
pathType: Prefix
102+
annotations: {} # Custom ingress annotations (optional)
103+
# nginx.ingress.kubernetes.io/rewrite-target: /
104+
# cert-manager.io/cluster-issuer: letsencrypt-prod
102105
tls:
103106
enabled: false # Set to true to enable TLS
104107
secretName: "" # Name of the TLS secret (auto-generated if empty)

0 commit comments

Comments
 (0)