-
Notifications
You must be signed in to change notification settings - Fork 42
Flash Unit and HDA Flowsheet Tutorial Revisions to reflect changes to initialization and scaling updates as well as some overall improvements #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tannerpolley
wants to merge
15
commits into
IDAES:main
Choose a base branch
from
tannerpolley:Tutorial-Update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o initialization and scaling
…o initialization and scaling
…ues that were causing a failed pytest
…ues that were causing a failed pytest
…ues that were causing a failed pytest
…ues that were causing a failed pytest
…ues that were causing a failed pytest
…ues that were causing a failed pytest
Contributor
|
This PR is waiting on IDAES/idaes-pse#1643 |
empty change to trigger github actions
…itialized the HDA flowsheet files to work with the modular properties framework. Currently not working due to unit model initialization error.
Contributor
|
Now waiting on IDAES/idaes-pse#1646 , but also we might want to use a different set of state variables, FpcTP has issues with degeneracy when a phase disappears. |
Member
|
@tannerpolley do you have time to look into this, perhaps restarting with a new PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(From #143)
For the Flash Unit Model tutorial, changes include:
For the HDA Flowsheet Tutorial, changed include:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
📚 Documentation preview 📚: https://idaes-examples--144.org.readthedocs.build/en/144/