Time constant of mean reaward is incorrect

[kappeld]

The time constant to compute the mean reward in the pattern matching example seems wrong. The update rate is computed here wrongly with hardcoded 1 ms instead of using the update step of the control node as defined in config.py

https://github.com/IGITUGraz/spore-nest-module/blob/master/examples/pattern_matching_showcase/python/experiment_utils/reward.py#L16

So the effective time constant deviates from the value in seconds (is 750 seconds instead of 50 seconds).

The line should read

self._gamma = np.exp(-music_node_timestep / self._normalization_window)

instead.

@mhoff can you confirm that?

The same problem might also be there in other examples.

[mhoff]

@mhoff can you confirm that?

I would agree.

The same problem might also be there in other examples.

Possibly. However, I checked the robotic experiments and they do not appear to be affected.