remove obsolete data from portal details cache

avoid missing details when getEntities replies that the portal has changed
while portal details is still fresh (3min) in cache

Author: le-jeu

core/code/map_data_render.js

@@ -347,7 +347,10 @@ window.Render.prototype.createPortalEntity = function(ent, details) {
     // in case of incomplete data while having fresh details in cache, update the portal with those details
     if (portalDetail.isFresh(guid)) {
       var oldDetails = portalDetail.get(guid);
-      if (marker.willUpdate(oldDetails))
+      if (data.timestamp > oldDetails.timestamp) {
+        // data is more recent than the cached details so we remove them from the cache
+        portalDetail.remove(guid);
+      } else if (marker.willUpdate(oldDetails))
         marker.updateDetails(oldDetails);
     }
 

core/code/portal_detail.js

@@ -25,6 +25,9 @@ window.portalDetail.isFresh = function(guid) {
   return cache.isFresh(guid);
 }
 
+window.portalDetail.remove = function(guid) {
+  return cache.remove(guid);
+}
 
 var handleResponse = function(deferred, guid, data, success) {
   if (!data || data.error || !data.result) {