Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draw-tools does't work on touch #3

Closed
johnd0e opened this issue Nov 24, 2018 · 3 comments
Closed

draw-tools does't work on touch #3

johnd0e opened this issue Nov 24, 2018 · 3 comments
Labels
bug Something isn't working mobile plugin

Comments

@johnd0e
Copy link
Contributor

johnd0e commented Nov 24, 2018 •
edited
Loading

There are 2 ways to fix it:

  1. As suggested in Update Leaflet.draw to release 0.3.0 for touch device support in DrawTools? iitc-project/ingress-intel-total-conversion#1142, leaflet.draw should be updated.
    And related fix: fix earth radius to same value used in leaflet and S2 iitc-project/ingress-intel-total-conversion#1244 (fix earth radius to same value used in leaflet and S2).
    More recents work on both issues is seen here: https://github.com/McBen/ingress-intel-total-conversion

  2. There is alternative fix: Fix. Touch events default passive to false iitc-project/ingress-intel-total-conversion#1261 (Touch events default passive to false).
    You can test it here: https://play.google.com/store/apps/details?id=com.cradle.iitc_mobile
modos189 added a commit that referenced this issue Nov 28, 2018
@modos189
Leaflet 1.3.0, leaflet.draw 1.0, google-layer using new Leaflet.Gridl…
68cf49f 
…ayer.GoogleMutant, various updates to support new libraries

thx https://github.com/McBen/ingress-intel-total-conversion/

#3
@johnd0e
Copy link
Contributor Author

johnd0e commented Dec 2, 2018

I see this issue is fixed now, thanks!

But icons at draw panel seem blurry.

@johnd0e
Copy link
Contributor Author

johnd0e commented Dec 3, 2018 •
edited
Loading

Leaflet 1.3.0, leaflet.draw 1.0, ...

Related fix: McBen@35ed971 (included in #10)

This was referenced Dec 3, 2018
Closed
Closed
Merged
Merged
Closed
@johnd0e johnd0e closed this as completed Dec 7, 2018
@johnd0e
Copy link
Contributor Author

johnd0e commented Dec 19, 2018

Perhaps McBen@1158ade + McBen@a3d34ce should be applied too.

@johnd0e johnd0e reopened this Dec 27, 2018
@modos189 modos189 added this to the IITC-CE v0.29 milestone Jan 15, 2019
modos189 added a commit that referenced this issue Jan 18, 2019
@modos189
Extracted leaflet monkey patching #3
551f4c9 
McBen@1158ade
McBen@a3d34ce
@johnd0e johnd0e closed this as completed Jan 18, 2019
@johnd0e johnd0e added bug Something isn't working plugin mobile labels Jan 23, 2019
tumik pushed a commit to tumik/iitc that referenced this issue Jan 28, 2019
@modos189
Merge pull request IITC-CE#3 from strguntbr/pull_request/possible_bui…
cbfc61b 
…ld.py_bug

build.py: loaderString should escape \-characters? #762
@johnd0e johnd0e removed this from the next milestone Apr 9, 2019
le-jeu pushed a commit to le-jeu/ingress-intel-total-conversion that referenced this issue Feb 7, 2021
@MysticJay
Merge pull request IITC-CE#3 from le-jeu/Portal-History
64d19b4 
fix previous commit
move getPortalHistoryDetails to portal_detail_display_tools
clavelm pushed a commit to clavelm/ingress-intel-total-conversion that referenced this issue Feb 10, 2021
@balthild
Merge pull request IITC-CE#3 from Ir1d/patch-2
f9f3881 
Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working mobile plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@modos189 @johnd0e