Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ensure spice to pointing frame and move to kernels.py #765

Closed
laspsandoval opened this issue Aug 21, 2024 · 0 comments · Fixed by #759
Closed

Add ensure spice to pointing frame and move to kernels.py #765

laspsandoval opened this issue Aug 21, 2024 · 0 comments · Fixed by #759
Assignees
Labels
SPICE Related to SPICE

Comments

@laspsandoval
Copy link
Contributor

Algorithm Description:

Requirements:

  • The functions in pointing_frame_handler.py should be in the imap_processing/spice/kernels.py module.
  • Add ensure spice decorator instead of mount path to efs and in other places currently using:

with spice.KernelPool(kernels):

The ensure_spice decorator is in place and I think should be used here. I pictured the input of this function to be a file path to the CK that should be used and that it would not contain any kernel furnishing code.

For your test, you can manually furnish only the kernels needed using fixture(s) similar to https://github.com/IMAP-Science-Operations-Center/imap_processing/blob/dev/imap_processing/tests/conftest.py#L44

@laspsandoval laspsandoval self-assigned this Aug 21, 2024
@laspsandoval laspsandoval added the SPICE Related to SPICE label Aug 21, 2024
@laspsandoval laspsandoval linked a pull request Aug 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SPICE Related to SPICE
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant