Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for XTCE packet parsing #784

Closed
2 tasks
greglucas opened this issue Aug 26, 2024 · 2 comments
Closed
2 tasks

Add tests for XTCE packet parsing #784

greglucas opened this issue Aug 26, 2024 · 2 comments
Labels
enhancement New feature or request Student Tasks suitable for student work

Comments

@greglucas
Copy link
Collaborator

Summary

There are currently no tests for the XTCE converter content. We should add some tests that mock up a spreadsheet and convert it to an XTCE file with the expected content.

Similar to the metadata_generation tools where we are mocking up spreadsheet tabs already: https://github.com/IMAP-Science-Operations-Center/imap_processing/blob/dev/tools/metadata_generation/tests/test_metadata_generation.py

Requirements

The more specific the better.

  • Mock up a spreadsheet with a few packets and tabs (don't add an Excel sheet to the repo)
  • Get full coverage for the XTCE converter class

Related tickets

No response

@greglucas greglucas added the enhancement New feature or request label Aug 26, 2024
@bourque bourque added the Student Tasks suitable for student work label Aug 27, 2024
@bourque
Copy link
Collaborator

bourque commented Aug 27, 2024

I think this could be a good student task, so I marked it as such

@greglucas
Copy link
Collaborator Author

greglucas commented Aug 30, 2024

Apparently we already had this in the test suite, so I'm going to close this issue as already completed. Sorry for the indirection here! See: #783 for a discussion of the updates to dynamically generate the file instead of using the manually saved version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Student Tasks suitable for student work
Projects
Status: Done
Development

No branches or pull requests

2 participants