Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoDICE: Add catdescs and fieldnames to housekeeping CDF attributes #776

Closed
Tracked by #252
bourque opened this issue Aug 21, 2024 · 1 comment · Fixed by #816
Closed
Tracked by #252

CoDICE: Add catdescs and fieldnames to housekeeping CDF attributes #776

bourque opened this issue Aug 21, 2024 · 1 comment · Fixed by #816
Assignees
@bourque
Labels
Ins: CoDICE Related to the CoDICE instrument Level: L1 Level 1 processing
Milestone
Sept 2024

Comments

@bourque
Copy link
Collaborator

bourque commented Aug 21, 2024

Currently the housekeeping data uses "TBD" for many of the catdesc and fieldname fields in the CDF attributes. These should be updated to actually store useful information. This could possibly be done programmatically by grabbing the short_description and long_description fields in the XTCE definition files. Perhaps something like:

for key, value in (packet.header | packet.data).items():
    fieldname = value.short_description
    catdesc = value.long_description
@bourque bourque added Ins: CoDICE Related to the CoDICE instrument Level: L1 Level 1 processing labels Aug 21, 2024
@bourque bourque self-assigned this Aug 21, 2024
@bourque bourque mentioned this issue Aug 21, 2024
Open
12 tasks
@greglucas
Copy link
Collaborator

Just an FYI that I agree we could do something like you mentioned here, but Tim brought up a good point during the PR review about trying to settle around the YAML definitions rather than programatically adding attributes so I removed it.
#687 (comment)

I suppose we could add a keyword argument to the function to allow that since it sounds like others have also wanted a similar thing. But in general, I think for now if it is just housekeeping data we ignore this and add the istp=False check to cdflib for l1 housekeeping files since it isn't required.

@bourque bourque added this to the Sept 2024 milestone Sep 6, 2024
@bourque bourque mentioned this issue Sep 6, 2024
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bourque bourque

Labels
Ins: CoDICE Related to the CoDICE instrument Level: L1 Level 1 processing
Projects
IMAP
Status: Done
Milestone
Sept 2024
Development

Successfully merging a pull request may close this issue.

Added FIELDNAMs, LABLAXISs, and CATDESCs for housekeeping attributes bourque/imap_processing
2 participants
@bourque @greglucas