Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new tof test data #807

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Added new tof test data #807

merged 9 commits into from
Sep 9, 2024

Conversation

laspsandoval
Copy link
Contributor

@laspsandoval laspsandoval commented Sep 4, 2024 •
edited
Loading

Change Summary

Overview

Added test data for tof that I recently received + another function.

Deleted Files

  • FM45_40P_Phi28p5_BeamCal_LinearScan_phi28.50_theta-0.00_Ultra_Image_Raw_Event_20240207T102746_withFSWcalcs.csv
    • Replaced by new test data.

Updated Files

  • ultra_l1b_extended.py
    • Added calculations for coincidence position and "etof"
  • conftest.py
    • Filename update
  • lookup_utils.py
    • Docstring update
  • FM45_Startup1_ULTRA_IMGPARAMS_20240719.csv
    • Parameter update

Testing

  • imap_processing/tests/ultra/unit/test_ultra_l1b_extended.py
    • Test ultra_l1b_extended.py
  • FM45_40P_Phi28p5_BeamCal_LinearScan_phi28.50_theta-0.00_Ultra_Image_Raw_Event_20240207T102746_withFSWcalcs.csv
    • New test data that includes tof and d values.

@laspsandoval laspsandoval self-assigned this Sep 4, 2024
@laspsandoval laspsandoval added Ins: Ultra Related to the IMAP-Ultra instrument Level: L1 Level 1 processing labels Sep 4, 2024
subagonsouth
subagonsouth reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. I would recommend trying to reduce the duplicated code in the new get_coincidence_positions() function.

imap_processing/ultra/l1b/ultra_l1b_extended.py Outdated Show resolved Hide resolved
imap_processing/ultra/l1b/ultra_l1b_extended.py Show resolved Hide resolved
subagonsouth
subagonsouth approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor. This looks good to me. I was also forced to learn that xarray.dataset.isel() is for "index select" instead of my ignorant assumption that it stood for "is element" 🤦

@laspsandoval laspsandoval merged commit b541737 into IMAP-Science-Operations-Center:dev Sep 9, 2024
17 checks passed
@laspsandoval laspsandoval deleted the ultra_l1b_extended_add_tof branch September 9, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subagonsouth subagonsouth subagonsouth approved these changes

@sdhoyt sdhoyt Awaiting requested review from sdhoyt

@greglucas greglucas Awaiting requested review from greglucas

@ndjhu ndjhu Awaiting requested review from ndjhu

Assignees

@laspsandoval laspsandoval

Labels
Ins: Ultra Related to the IMAP-Ultra instrument Level: L1 Level 1 processing
Projects
IMAP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laspsandoval @greglucas @subagonsouth