Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate parameter handling with connection status #564

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

knmcguire
Copy link
Collaborator

Should fix the biggest delay with #560

@knmcguire
Copy link
Collaborator Author

Still will need to test this if this works.

@knmcguire
Copy link
Collaborator Author

I had some issues of using set_param before the param values has been received as that is blocked from the cflib, so I used a intermediate solution, which is set_param_raw(), after we have received the toc, which should work out (see this issue: bitcraze/crazyflie-lib-python#475). This connects with the crazyflie directly instead of the toc/value layer in the cflib and enables setting the parameters earlier. Not an ideal approach but it works out.

I think we should perhaps have a parameter that indicates that the crazyflie is flight ready, not based on the status but based on the crazyswarm2 initialization of the yaml file, but that should probably be related to an issue.

Anyway, PR is ready for review.

@knmcguire knmcguire marked this pull request as ready for review September 12, 2024 14:57
@knmcguire knmcguire requested a review from whoenig September 12, 2024 14:57
Copy link

@whoenig whoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks!

crazyflie/scripts/crazyflie_server.py Outdated Show resolved Hide resolved
@knmcguire
Copy link
Collaborator Author

great! I've removed the print and I'll merge

@knmcguire knmcguire merged commit a872237 into main Sep 12, 2024
5 checks passed
@knmcguire knmcguire deleted the seperate_connection_status branch September 12, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants