From 236f1ad80943c0e928aa785793165519f1ab37c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Est=C3=A8ve?= Date: Thu, 2 Jan 2025 16:32:44 +0100 Subject: [PATCH 1/2] MNT Use actions/download-artifact v4 that supports downloading artifact from workflow run-id --- .github/workflows/deploy-gh-pages.yml | 2 +- .github/workflows/jupyter-book-pr-preview.yml | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/deploy-gh-pages.yml b/.github/workflows/deploy-gh-pages.yml index e12f9f7c6..4091264a8 100644 --- a/.github/workflows/deploy-gh-pages.yml +++ b/.github/workflows/deploy-gh-pages.yml @@ -58,7 +58,7 @@ jobs: - name: Upload jupyter-book artifact for preview in PRs if: ${{ github.event_name == 'pull_request' }} - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: jupyter-book path: | diff --git a/.github/workflows/jupyter-book-pr-preview.yml b/.github/workflows/jupyter-book-pr-preview.yml index b423f4168..1425a0c77 100644 --- a/.github/workflows/jupyter-book-pr-preview.yml +++ b/.github/workflows/jupyter-book-pr-preview.yml @@ -19,11 +19,10 @@ jobs: sha: ${{ github.event.workflow_run.head_sha }} context: 'JupyterBook preview' - - uses: dawidd6/action-download-artifact@v2 + - uses: actions/download-artifact@v4 with: github_token: ${{secrets.GITHUB_TOKEN}} - workflow: deploy-gh-pages.yml - run_id: ${{ github.event.workflow_run.id }} + run-id: ${{ github.event.workflow_run.id }} name: jupyter-book - name: Get pull request number From 9bd1d717fe640cdcc53976f2700f3f8eaa6ac2f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Est=C3=A8ve?= Date: Thu, 2 Jan 2025 17:05:25 +0100 Subject: [PATCH 2/2] Fix typo --- .github/workflows/jupyter-book-pr-preview.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/jupyter-book-pr-preview.yml b/.github/workflows/jupyter-book-pr-preview.yml index 1425a0c77..c23c2e999 100644 --- a/.github/workflows/jupyter-book-pr-preview.yml +++ b/.github/workflows/jupyter-book-pr-preview.yml @@ -21,7 +21,7 @@ jobs: - uses: actions/download-artifact@v4 with: - github_token: ${{secrets.GITHUB_TOKEN}} + github-token: ${{secrets.GITHUB_TOKEN}} run-id: ${{ github.event.workflow_run.id }} name: jupyter-book