-
Notifications
You must be signed in to change notification settings - Fork 0
IONOS(theme): fix darkmode for logo #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the dark mode styling for the IONOS logo by consolidating the CSS rules. The media query for dark mode color scheme is moved from a standalone block into a nested rule within the .logo selector, improving code organization and maintainability.
- Nested the dark mode media query directly within the
.logoselector - Removed the duplicate standalone media query block targeting
#header .logo
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @media (prefers-color-scheme: dark) { | ||
| filter: invert(100%) saturate(1%) brightness(99%) contrast(200%); | ||
| } | ||
| } |
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation is inconsistent. The media query and its contents use two tabs, but should use one tab to align with the parent .logo selector's nesting level.
| @media (prefers-color-scheme: dark) { | |
| filter: invert(100%) saturate(1%) brightness(99%) contrast(200%); | |
| } | |
| } | |
| @media (prefers-color-scheme: dark) { | |
| filter: invert(100%) saturate(1%) brightness(99%) contrast(200%); | |
| } | |
| } |
c485633 to
596fa1e
Compare
|
this last 596fa1e commit breaks logo color on login page: it's orange in both light and dark mode. |
Will check... |
Additional increase logo size on login Signed-off-by: Matthias Sauer <[email protected]>
- same size as on non-public page - supports darkmode now - add darkmode for subtitle (e.g. shared folder name) Signed-off-by: Matthias Sauer <[email protected]>
596fa1e to
78c6dd9
Compare
Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
this avoids overlapping with logo Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now it's okay, at least better then before!
moved media query for logo darkmode to proper location