Skip to content

Conversation

@matsaur
Copy link

@matsaur matsaur commented Oct 31, 2025

moved media query for logo darkmode to proper location

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the dark mode styling for the IONOS logo by consolidating the CSS rules. The media query for dark mode color scheme is moved from a standalone block into a nested rule within the .logo selector, improving code organization and maintainability.

  • Nested the dark mode media query directly within the .logo selector
  • Removed the duplicate standalone media query block targeting #header .logo

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 21 to 26
@media (prefers-color-scheme: dark) {
filter: invert(100%) saturate(1%) brightness(99%) contrast(200%);
}
}
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is inconsistent. The media query and its contents use two tabs, but should use one tab to align with the parent .logo selector's nesting level.

Suggested change
@media (prefers-color-scheme: dark) {
filter: invert(100%) saturate(1%) brightness(99%) contrast(200%);
}
}
@media (prefers-color-scheme: dark) {
filter: invert(100%) saturate(1%) brightness(99%) contrast(200%);
}
}

Copilot uses AI. Check for mistakes.
@matsaur matsaur requested a review from tanyaka October 31, 2025 10:14
@tanyaka
Copy link

tanyaka commented Oct 31, 2025

this last 596fa1e commit breaks logo color on login page: it's orange in both light and dark mode.

@matsaur
Copy link
Author

matsaur commented Oct 31, 2025

this last 596fa1e commit breaks logo color on login page: it's orange in both light and dark mode.

Will check...

Matthias Sauer added 2 commits October 31, 2025 16:47
Additional increase logo size on login

Signed-off-by: Matthias Sauer <[email protected]>
- same size as on non-public page
- supports darkmode now
- add darkmode for subtitle (e.g. shared folder name)


Signed-off-by: Matthias Sauer <[email protected]>
@matsaur matsaur force-pushed the ms/fix/darkmode_logo branch from 596fa1e to 78c6dd9 Compare October 31, 2025 15:51
Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
this avoids overlapping with logo

Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
Copy link

@tanyaka tanyaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now it's okay, at least better then before!

@tanyaka tanyaka merged commit 5d05ec5 into ionos-dev Oct 31, 2025
33 of 35 checks passed
@printminion-co printminion-co deleted the ms/fix/darkmode_logo branch October 31, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants