Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize header inclusion #177

Open
matt-frey opened this issue Jun 14, 2023 · 1 comment
Open

Reorganize header inclusion #177

matt-frey opened this issue Jun 14, 2023 · 1 comment
Labels
cleanup

Comments

@matt-frey
Copy link
Member

In GitLab by @vinciguerra_a on Jun 14, 2023, 13:24

The IPPL wiki should be updated to describe some best practices and a set of conventions for #includes and forward declarations in header files. The headers in IPPL then need to be updated to follow these best practices to ensure that all types are properly defined or declared wherever they appear and that there is no dependence on #include directives appearing in a particular order (see !160).

In addition, different sections of IPPL should be grouped together such that end-users can #include a single file to gain access to the components they need, e.g. IPPL core, solvers, etc.
felixschurk pushed a commit that referenced this issue Dec 8, 2023
@s-mayani
Merge branch '177-p3m-particle-mesh-solver-crashes-in-scatter' into '…
e5547f3 
…master'

Resolve "P3M Particle-Mesh solver crashes in scatter"

Closes #177

See merge request OPAL/Libraries/ippl!187
@Arc676
Copy link
Contributor

Arc676 commented Sep 22, 2024

This issue is potentially superseded by #293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matt-frey @Arc676