Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary protocol ACK responses to SET messages #48

Open
TjazVracko opened this issue Aug 22, 2023 · 0 comments
Open

Binary protocol ACK responses to SET messages #48

TjazVracko opened this issue Aug 22, 2023 · 0 comments
Labels
type: feature request New feature or request.

Comments

@TjazVracko
Copy link
Collaborator

TjazVracko commented Aug 22, 2023

Context

Currently, a SET message has no built-in response. The user must issue a GET command to see if the SET was successful.
This is not good for non-realtime uses of the binary protocol (like LoRaWAN). It would be nice to schedule a SET on the server and receive a GET of the same setting back, or some kind of ACK/NACK

Required steps / Implementation details

Two options:

  • implement an ACK/NACK response for SET commands
  • implement add GET response to SET and GET_FULL response to SET_DEFAULT. What happens if the SET fails in this case?

We must also test the robustness of the protocol when "random" values are sent, when a valid setting is set with a wrong value len, ... (We need unit tests for the user_settings_protocol_executor, basically).

Definition of Done

SET command generates some kind of response.

@TjazVracko TjazVracko added the type: feature request New feature or request. label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature or request.
Projects
None yet
Development

No branches or pull requests

1 participant