Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI: Fix OPI Import error #4350

Closed
John-Holt-Tessella opened this issue May 15, 2019 · 1 comment · Fixed by ISISComputingGroup/ibex_gui#885
Closed

GUI: Fix OPI Import error #4350

John-Holt-Tessella opened this issue May 15, 2019 · 1 comment · Fixed by ISISComputingGroup/ibex_gui#885
Assignees
@John-Holt-Tessella

Comments

@John-Holt-Tessella
Copy link
Contributor

John-Holt-Tessella commented May 15, 2019 •
edited
Loading

As a developer I want to be able to import scripts into python calls from an OPI. This has broken between moving to latest CSS. There is a hack for the CAEN HV which does a manual import of the files (read copy and paste) This must be undone as part of this.

See comments for how it is bocken and a possible fix.

Acceptance Criteria

  1. Manual import has been removed from ticket (HVCAEN OPI does not allow seeing/editing the list of channels #4341), namely files:
    • ibex_gui_e4\base\uk.ac.stfc.isis.ibex.opis\resources\HV\Scripts\DisplaySummary.py
    • ibex_gui_e4\base\uk.ac.stfc.isis.ibex.opis\resources\HV\Scripts\DisplayChannels.py
  2. Imports work correctly
  3. There is a squish test for this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@John-Holt-Tessella John-Holt-Tessella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hack to make imports work see #4350 ISISComputingGroup/ibex_gui
1 participant
@John-Holt-Tessella