Skip to content

Commit 9f2d051

Browse files
committed
review comments
1 parent 50ba79b commit 9f2d051

File tree

5 files changed

+4
-5
lines changed

5 files changed

+4
-5
lines changed

.github/workflows/Lint-and-test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@ jobs:
2020
uses: ISISComputingGroup/reusable-workflows/.github/workflows/linters.yml@main
2121
with:
2222
compare-branch: origin/main
23-
python-ver: '3.12'
23+
python-ver: '3.11'
2424
tests:
2525
runs-on: ubuntu-latest
2626
steps:
2727
- uses: actions/checkout@v4
2828
- name: Install uv and set the python version
2929
uses: astral-sh/setup-uv@v6
3030
with:
31-
python-version: "3.12"
31+
python-version: "3.11"
3232
- name: Install dependencies
3333
run: uv sync --all-extras --dev
3434
- name: Test with pytest

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ name = "ibex-non-ca-helpers"
77
dynamic = ["version"]
88
description = "Python helpers for IBEX which do not rely on channel access"
99
readme = "README.md"
10-
requires-python = ">=3.12"
10+
requires-python = ">=3.11"
1111
dependencies = [
1212
]
1313

src/ibex_non_ca_helpers/macros.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,4 @@ def get_macro_values() -> Dict[str, str]:
1111
"""
1212
macros = json.loads(os.environ.get("MACROS", "{}"))
1313
macros = {key: value for (key, value) in macros.items()}
14-
print("Defined macros: " + str(macros))
1514
return macros

tests/test_hex.py renamed to tests/test_compress_hex.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import pytest
44

5-
from ibex_non_ca_helpers.hex import (
5+
from ibex_non_ca_helpers.compress_hex import (
66
compress_and_hex,
77
dehex_and_decompress,
88
dehex_and_decompress_waveform,

0 commit comments

Comments
 (0)