Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all model & guess fitting functions #74

Open
jackbdoughty opened this issue Nov 22, 2024 · 2 comments
Open

Check all model & guess fitting functions #74

jackbdoughty opened this issue Nov 22, 2024 · 2 comments

Comments

@jackbdoughty
Copy link
Contributor

Check that in all model & guess functions, that they behave for all inputs e.g must check all for flat data as this is most likely to cause problems (div by 0 errors).

@Tom-Willemsen
Copy link
Contributor

Tom-Willemsen commented Nov 25, 2024

For the guess functions, if they really can't guess a sensible value for a parameter (e.g. guessing the centre of a gaussian with amplitude zero) then make them fall back to very simple guesses - e.g. always guess centre of gaussian is in middle of x range, guess a height of 1, etc... This is still "better than nothing" as a guess for the optimizer.

@Tom-Willemsen
Copy link
Contributor

For a LinearFit we were seeing a consistent RankWarning on the first point measured.

Suspect this is because at some point, we tried to "guess" at a linear fit with just one point. Catch this case and don't try to guess for the very first point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants