-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chapter 14 Improvement #140
Comments
Okay - Equation 1: Are you saying that the denominator "hours" in the second variable should be "days"? I think I agree and can you change it? Do I need to change it? Do you want me to check with the author first? I will check nonetheless since I will be reaching out to him. Equation 2: I agree. We can change it to Total days in the year - holidays - vacation - PTO (personal time off such as sick days) = available working days; although he wants to create a ratio...so let me check with the author about this as well, as I am not sure what he is trying to do here. Okay? Exchange rate urls should just be deleted Thanks for the diligence. Much appreciated |
Did this without regard for the construction of narrative, in less than half hour it was easier than discuss properly what I think is wrong. (which I briefly do in issue ITDP#140). Subject to Aimée's approval after consulting with Diogo. Also: - Removes conversion urls - Fix table title - typo (see issue ITDP#140)
I made provisional changes as I see fit, will wait for approval before merge (pr #146 ... to follow click in "show all checks" and "publication" at the end of the pull request): Table title: "Fuel consuptiom cost by vehicle type" Equation 1:
Equation 2:
|
Did this without regard for the construction of narrative, in less than half hour it was easier than discuss properly what I think is wrong. (which I briefly do in issue ITDP#140). Subject to Aimée's approval after consulting with Diogo. Also: - Removes conversion urls - Fix table title - typo (see issue ITDP#140)
Did this without regard for the construction of narrative, in less than half hour it was easier than discuss properly what I think is wrong. (which I briefly do in issue ITDP#140). Subject to Aimée's approval after consulting with Diogo. Also: - Removes conversion urls - Fix table title - typo (see issue ITDP#140)
I never heard from Diogo - will follow up now. |
Noticed the following during conversion:
Status:
The text was updated successfully, but these errors were encountered: