Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Cannot refresh page when only 1 study per user is allowed #7374

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 17, 2025

What do these changes do?

NOTE: this should probably go in a hotfix if it works

comparison between UUID and str never resolves

Related issue/s

How to test

Dev-ops checklist

Sorry, something went wrong.

@sanderegg sanderegg added the a:webserver issue related to the webserver service label Mar 17, 2025
@sanderegg sanderegg added this to the The Awakening milestone Mar 17, 2025
@sanderegg sanderegg self-assigned this Mar 17, 2025
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.08%. Comparing base (a387fb7) to head (1b149b1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7374      +/-   ##
==========================================
- Coverage   87.28%   84.08%   -3.21%     
==========================================
  Files        1709      659    -1050     
  Lines       66325    31578   -34747     
  Branches     1124      168     -956     
==========================================
- Hits        57895    26552   -31343     
+ Misses       8110     4968    -3142     
+ Partials      320       58     -262     
Flag Coverage Δ
integrationtests 59.85% <ø> (ø)
unittests ∅ <ø> (∅)
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk ∅ <ø> (∅)
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 ∅ <ø> (∅)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.34% <ø> (-0.95%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 41.89% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a387fb7...1b149b1. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one

@sanderegg sanderegg force-pushed the webserver/bugfix-i1861 branch from 8e12678 to 68ee8b4 Compare March 18, 2025 07:02
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@sanderegg sanderegg force-pushed the webserver/bugfix-i1861 branch from 68ee8b4 to e28cea9 Compare March 18, 2025 08:42
@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 18, 2025
@sanderegg
Copy link
Member Author

@mergify queue

Copy link
Contributor

mergify bot commented Mar 18, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 5aed474

@mergify mergify bot merged commit 5aed474 into ITISFoundation:master Mar 18, 2025
93 of 95 checks passed
sanderegg added a commit that referenced this pull request Mar 18, 2025
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@sanderegg sanderegg mentioned this pull request Mar 18, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖-automerge marks PR as ready to be merged for Mergify a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot access study after refreshing F5, unable to get back in project
5 participants