Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URGENT: BUG: Editing an approved booking request does not change its status in the booking tool. #469

Open
nopivnick opened this issue Oct 27, 2024 · 3 comments
Labels
bug Something isn't working Business logic GCP
Milestone

Comments

@nopivnick
Copy link
Collaborator

to replicate:

  1. submit a request for rooms 221 & 222 that's longer than 4 hours (not auto-approve eligible)
  2. as a liaison, pre-approve the request
  3. as a final approver, approve the request
  4. as a user, edit the request to less than 4 hours, add equipment, and re-submit the request
  5. observe a request email notification is sent to the liaison but the status of the edited request does not change (it remains APPROVED and doesn't appear under Liaison » Bookings table).

expected behavior:

  1. submit a request for rooms 221 & 222 that's longer than 4 hours (not auto-approve eligible)
  2. as a liaison, pre-approve the request
  3. as a final approver, approve the request
  4. as a user, edit the request to less than 4 hours, add equipment, and re-submit the request
  5. the request should change status to REQUESTED and should appear under Liaison » Bookings table.
@nopivnick nopivnick added bug Something isn't working Business logic GCP labels Oct 27, 2024
@nopivnick nopivnick added this to the 2025 Spring milestone Oct 27, 2024
@lucia-gomez
Copy link
Collaborator

what deploy was this on? usually shouldn't matter but with all of the recent refactoring it could

@nopivnick
Copy link
Collaborator Author

@lucia-gomez it was on production.

@lucia-gomez
Copy link
Collaborator

ok i see the problem, trying to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Business logic GCP
Projects
None yet
Development

No branches or pull requests

2 participants