From 2b44f86f9c527d6e8f59ba893899d4dfdfbd3d23 Mon Sep 17 00:00:00 2001
From: Pierre Kancir <pierre.kancir.emn@gmail.com>
Date: Fri, 3 Sep 2021 15:14:56 +0200
Subject: [PATCH] AP_HAL: fix ringbuffer test on clang.

../../libraries/AP_HAL/utility/tests/test_ringbuffer.cpp:46:17: fatal error: variable-sized object may not be initialized
    uint8_t buf[strlen(str)+5] {};
---
 libraries/AP_HAL/utility/tests/test_ringbuffer.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/libraries/AP_HAL/utility/tests/test_ringbuffer.cpp b/libraries/AP_HAL/utility/tests/test_ringbuffer.cpp
index bdcf41446fed4..95f608ef70f1e 100644
--- a/libraries/AP_HAL/utility/tests/test_ringbuffer.cpp
+++ b/libraries/AP_HAL/utility/tests/test_ringbuffer.cpp
@@ -41,9 +41,10 @@ TEST(ByteBufferTest, Basic)
     EXPECT_EQ(x.space(), unsigned(size-1));
     EXPECT_TRUE(x.is_empty());
 
-    static const char *str = "fo";
+    constexpr auto str_size = 3;
+    static const char str[str_size] = "fo";
     EXPECT_EQ(x.write((uint8_t*)str, 2), 2U);
-    uint8_t buf[strlen(str)+5] {};
+    uint8_t buf[str_size+5] {};
     EXPECT_EQ(x.read(buf, sizeof(buf)), 2U);
     EXPECT_STREQ((char*)buf, (char*)str);
 }