Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose SPE.Emitter.disable() and SPE.Emitter.enable() #21

Open
UXVirtual opened this issue May 15, 2017 · 1 comment
Open

Expose SPE.Emitter.disable() and SPE.Emitter.enable() #21

UXVirtual opened this issue May 15, 2017 · 1 comment

Comments

@UXVirtual
Copy link
Contributor

I'd be great to expose the disable() and enable() methods on SPE.Emitter as component methods. Currently I have to do the following if I want to start / stop the emitter:

var particleEntity = document.querySelector('[particle-system]');
particleEntity.components['particle-system'].particleGroup.emitters[0].disable();
particleEntity.components['particle-system'].particleGroup.emitters[0].enable();

Having the above would allow the component to be used more easily for temporary effects such as object collisions / teleport effects etc.

I'm assuming this component only ever creates one particle emitter?

@UXVirtual UXVirtual changed the title Expose Emitter.disable() and Emitter.enable() Expose SPE.Emitter.disable() and SPE.Emitter.enable() May 15, 2017
joshmarinacci added a commit to joshmarinacci/aframe-particle-system-component that referenced this issue Nov 30, 2017
fix for IdeaSpaceVR#21
add enabled property
@kfarr
Copy link
Contributor

kfarr commented Dec 3, 2017

This issue can be closed? Looks complete with joshmarinacci@551488c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants