pug-lint bugs

[brianhelba]

Girder's .pug-lintrc file enables the rules requireLowerCaseTags and validateAttributeSeparator, but both have buggy behavior.

• requireLowerCaseTags fails with our use of SVG definitions elements. This is a known issue upstream: Add support of Array of allowed uppercase tags for requireLowerCaseAttributes  pugjs/pug-lint#108
• validateAttributeSeparator is bugged when using multiLineSeparator. First, the tokenizer is buggy, causing unexpected matching of additional indentation whitespace. Second, the multiLineSeparator argument needs to take a RegEx, in order to accommodate variable spacing due to indentation.

To fully resolve this issue:

• the bugs must be fixed upstream
• upstream pug-lint must make a new release
• Girder must upgrade to the new release
• this plugin must upgrade to the new Girder
• the commit 42d1adf must be reverted