Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore: Multi-image Lesion window #107

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Restore: Multi-image Lesion window #107

merged 6 commits into from
Aug 12, 2024

Conversation

brianhelba
Copy link
Member

Restore #105

Merging branch for Multi-image Lesion window after review from Jochen, Nick, and Veronica.
Copy link

cloudflare-workers-and-pages bot commented Aug 6, 2024

Deploying isic-display-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: cd1fb00
Status: ✅  Deploy successful!
Preview URL: https://6dc11f74.isic-display-ui.pages.dev
Branch Preview URL: https://restore-multilesion.isic-display-ui.pages.dev

View logs

@brianhelba
Copy link
Member Author

@volishevko I think I've found a bug in #105 that was only showing up in Production. The bug causes the images within the gallery to not load:
image
However, no console errors are shown.


After some debugging, I noticed that when connected to the Sandbox API, the request to /api/v2/lesions/ is relatively fast, and it tends to respond before some of the later API calls. However, on the Production API, it looks like /api/v2/lesions/ is significantly slower (taking ~3s).

When I used an extension like URL Throttler to artificially slow down just the /api/v2/lesions/ endpoint when connected to the Sandbox API, I was able to reproduce the original bug.

We're working to make /api/v2/lesions/ faster on Production, but we can't guarantee that API requests will respond in any particular order or amount of time. So, the race condition here should be fixed.

@brianhelba brianhelba marked this pull request as draft August 6, 2024 17:02
@volishevko volishevko marked this pull request as ready for review August 9, 2024 06:20
@neuroelf neuroelf merged commit 522f8a2 into master Aug 12, 2024
3 checks passed
@neuroelf neuroelf deleted the restore-multilesion branch August 12, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants