Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prove continuity of map K_v -> L_w #215

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

javierlcontreras
Copy link

@javierlcontreras javierlcontreras commented Nov 11, 2024

Code dictated by Yaël

Closes #204

Copy link
Collaborator

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the sorries is false right now, as far as I can see.

FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Outdated Show resolved Hide resolved
FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Outdated Show resolved Hide resolved
FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Outdated Show resolved Hide resolved
@kbuzzard
Copy link
Collaborator

Can one of you write a message just saying claim in #204 ?

@YaelDillies
Copy link
Collaborator

If you're against merging with a false sorry, then I suggest we wait a week or two for my refactor(s) to hit mathlib. It's quite inconvenient to work around.

@kbuzzard
Copy link
Collaborator

I'm definitely against merging with a false sorry! Sorry :-)

@YaelDillies
Copy link
Collaborator

Actually, this PR has a net count of 1 - 1 = 0 new false sorries ;)

@kbuzzard
Copy link
Collaborator

kbuzzard commented Nov 13, 2024

Yes but that doesn't stop me objecting to the addition of a new false sorry: I don't think total count is meaningful here. In fact the old false sorry (my fault -- a sign error) is removed on main already (which presumably is the cause of the conflict)

@YaelDillies
Copy link
Collaborator

Somehow when I merged master it overwrote the new version of the file without telling me. I'll revert what I spot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continuity of map of local fields K_v -> L_w coming from number fields
3 participants