Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible auth issues when using both SessionAuthentication and TokenAuthentication #53

Open
jcohen02 opened this issue Apr 15, 2021 · 3 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jcohen02
Copy link
Collaborator

As originally highlighted in #43, there are reports of issues when using using both SessionAuthentication and TokenAuthentication in 'DEFAULT_AUTHENTICATION_CLASSES'.

It's not clear whether this works in some circumstances because requests contain support for both authentication types and not in others where only the required headers/content are provided to support one auth type, or whether something else is going on.

This needs further investigation and the documentation will likely need updating to highlight this and provide guidance on avoiding the issue.

@jcohen02 jcohen02 added bug Something isn't working help wanted Extra attention is needed labels Apr 15, 2021
@jcohen02 jcohen02 self-assigned this Apr 15, 2021
@devinvenable
Copy link

As a workaround I explicitly added:

class ProcessView(APIView):
...
authentication_classes = [BasicAuthentication,]

@devinvenable
Copy link

...this solved it for me, by specifically limiting the auth classes on the View that was complaining.

@jcohen02
Copy link
Collaborator Author

Just a quick update on this issue to say that I've been trying to reproduce the issue originally described in #43 and have been unable to do so at present. I've just added a description of what I've tried in response to the most recent message in #43. If anyone else is experiencing this issue and would be able to provide a minimal example to reproduce it, that would be very helpful.

At present, I'm assuming this is something specific to the configuration of the apps where the problem is being encountered since a cut-down small-scale test doesn't reproduce the problem. Nonetheless, I'd be really pleased to receive any further details that can help me to identify what's causing this and put in a fix asap, if there is, indeed, something that can be done within django-drf-filepond to help address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants