-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filepond 'restore' point (and possibly other endpoints) currently provides the id in the path, this lib expects it as a query parameter #98
Comments
Hi @browze, thanks for highlighting this discrepancy between the way that the current version of filepond creates requests when using the I've also been really busy and have a number of updates to work on with this library but this issue is hopefully something that is quite straightforward to fix so I'll aim to get this sorted out as soon as possible and included in the next release. I'm hoping to get a new release out soon and it sounds like you have a temporary workaround in place for now. |
Hi @browze, I've just been looking into this. I may be misunderstanding, so apologies if that's the case, but I actually think the issue you're highlighting here is controlled by the way you specify the endpoints in your I can't honestly remember the reason for selecting the use of an In fact, if you look at the relevant section of the filepond server docs, they give an example of the use of a query string parameter named after the relevant method, e.g. Assuming I'm not misunderstanding things here, I think you can resolve this simply by setting the
I'll make this clearer in the docs. |
This is hopefully addressed in #109 but do let me know if it's not - I'll leave this issue open for now. |
The following code using the current version of Filepond (https://unpkg.com/filepond@^4/dist/filepond.js):
produces this request when Filepond executes:
<...your-url-config-path>/restore/12345
...[A]Whereas this lib appears to currently expect:
<...your-url-config-path>/restore/?id=12345
...[B]In other words it tries to access the id as a key on request.GET
Can fork and submit a pull request later perhaps, if you haven't gotten around to fixing, but as really busy right now as a temporary work around I'm just subclassing the restore view and redirecting A to B.
The text was updated successfully, but these errors were encountered: