-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review IMAP SDC decompression work #26
Comments
PR for this is at IMAP-Science-Operations-Center/imap_processing#801
|
Thank you Alastair for reviewing this PR! Maxine and we appreciate your feedbacks |
Code review done, lots of minor stuff, nothing major. Maxine has flagged some issues she found in some packets - "that the end of the secondary vectors is cut off.... data I sent is from SHCOARSE time 461974160. " Have asked @mfacchinelli to plot it More info on the bad data
|
We have sent the data back to maxine for review, seems like a couple of issues in the logic. |
Maxine has fixed bug and science now matches our data results except for a know issue with a 5s offset. Done. |
Maxine says that the "container is up and running" for the decompression processing logic. I assume this is the thing which actions API calls to the SDC data integration endpoints.
The text was updated successfully, but these errors were encountered: