Skip to content

Outdated and inappropriate comment on ESP32 analogWrite() support #19

@Kaloha

Description

@Kaloha

Hi, thank you for sharing this display driver—it’s very helpful for ESP32 developers.

While reviewing the code, I found this section in Waveshare_ILI9486.cpp:

// SERIOUSLY?  No analogWrite on this platform?  Idiots.
void analogWrite(uint8_t pin, uint8_t val)
{
    digitalWrite(pin, val ? HIGH : LOW);
}

I wanted to point out two things:

The language in the comment ("Idiots") could be seen as offensive or unprofessional. Since this is a public open-source project, a more neutral tone is generally recommended to maintain a respectful and inclusive community.

The information is outdated — ESP32 (using the Arduino core) now does support

So this section could be updated or removed, and the comment revised to reflect current support. I’d be happy to help submit a PR for this if needed.

Thanks again for your efforts maintaining this library!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions