Keep downloaded release asset if installation fails

[jm355]

Describe the feature
When an app fails to install, it would be nice if obtainium held onto the downloaded release asset until either the app gets updated or a newer release becomes available. This way, attempting to update again would not need to re-download the apk/xapk, and pressing "download release asset" could simply copy the cached file to Downloads

[ImranR98]

An installation failure usually means the downloaded file is invalid, what's the point of keeping it?

[jm355]

Not necessarily, it depends why the install failed. In #682, obtainium fails to install the xapk, but using the package manager app the xapk downloaded via the download release asset button installs fine.

Another option would be, if an apk/xapk fails to install, offer to move it to Downloads, so the user can investigate whether the issue is with the file or not

[tutacat]

If you manually cancel or click away installation dialog, it deletes it instantly, it shouldn't do that at least.

Agreed, I think cache should be kept (up to 1, and settings ofc.) and check if there is a cache before downloading. There are many ways to implement this, and you would add a confirmation between installing the downloaded version and downloading again.

I will look at implementation even just for a fork.

[NripPrajapat]

Sometimes it does it with sizuku permission not granted, any way there is no harm in letting the file stay there, or sometimes it generates wrong version and system would not install file and it gets deleted.

Summary is it should stay or at least provide and option to keep it.
Thanks.