Skip to content

Commit 067a9e3

Browse files
authored
fix(preview): run Wrangler from static output (#80)
* fix(preview): run Wrangler from static output - keep npm away from the pnpm catalog workspace during Pages deploy * test(preview): follow static Wrangler directory
1 parent fd80719 commit 067a9e3

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

‎.github/workflows/pages-preview.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,9 +185,9 @@ jobs:
185185
accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
186186
packageManager: npm
187187
wranglerVersion: 4.114.0
188-
workingDirectory: candidate
188+
workingDirectory: candidate/apps/client-web/dist
189189
command: >-
190-
pages deploy apps/client-web/dist
190+
pages deploy .
191191
--project-name=${{ vars.CLOUDFLARE_PAGES_PROJECT }}
192192
--branch=${{ needs.identity.outputs.branch }}
193193
--commit-hash=${{ needs.identity.outputs.head_sha }}

‎scripts/native-extension-distribution.test.mjs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,8 @@ test('separates exact-main app delivery from the Changesets Extension release li
306306
assert.match(preview, /pnpm build/)
307307
assert.match(preview, /pdm run inkcre-ext preview build/)
308308
assert.match(preview, /--public-origin "\$PREVIEW_ORIGIN"/)
309-
assert.match(preview, /pages deploy apps\/client-web\/dist/)
309+
assert.match(preview, /workingDirectory: candidate\/apps\/client-web\/dist/)
310+
assert.match(preview, /pages deploy \./)
310311
assert.doesNotMatch(preview, /INKCRE_EXTENSION_REGISTRY_TOKEN/)
311312

312313
assert.doesNotMatch(release, /pages deploy/)

0 commit comments

Comments
 (0)