Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Incendo/cloud-minecraft-modded
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6b740f2649bbf85c82eb2685696760546fcfce1e
Choose a base ref
..
head repository: Incendo/cloud-minecraft-modded
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cc58d609632e53233e901a940fb00a254f98a752
Choose a head ref
Showing with 5 additions and 2 deletions.
  1. +4 −1 ...ed-common/src/main/java/org/incendo/cloud/minecraft/modded/internal/ModdedSignedStringMapper.java
  2. +1 −1 gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -78,8 +78,11 @@ public CompletableFuture<ArgumentParseResult<SignedString>> apply(
} else {
return ArgumentParseResult.successFuture(SignedString.unsigned(str));
}
if (signedArgs.isEmpty()) {
return ArgumentParseResult.successFuture(SignedString.unsigned(str));
}
if (signedArgs.size() != 1) {
throw new IllegalStateException();
throw new IllegalStateException("Found more signed arguments than expected (" + signedArgs.size() + ")");
}

return ArgumentParseResult.successFuture(
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ cloud-build-logic = "0.0.15"
checkstyle = "10.12.5"
stylecheck = "0.2.1"
ktlint = "0.50.0"
errorprone = "2.29.2"
errorprone = "2.30.0"

cloud = "2.0.0-rc.2"
cloudMinecraft = "2.0.0-beta.9"