Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we loosen the urllib3 requirement? #27

Open
will-byrne-cardano opened this issue Feb 3, 2025 · 2 comments
Open

can we loosen the urllib3 requirement? #27

will-byrne-cardano opened this issue Feb 3, 2025 · 2 comments
Assignees

Comments

@will-byrne-cardano
Copy link

The urllib3 requirement is rather restrictive given that it's only direct usage seems to be here

Would it be possible to unpin this requirement and allow it to follow the conventions of the botocore library?

https://github.com/boto/botocore/blob/33ef2f747f5cd794018ece3eda4d3908c869ba80/setup.py#L31-L32

In addition, would you be open to including the AWS Auth features as a package extra rather than being included in the core lib (happy to put in a PR). That way the core functionality of this library can depend on as little as possible.

We'd like to use this SDK, but with the current requirements it has pinned it's not possible and we need to revert to using requests.

@DanielHougaard
Copy link
Contributor

Hi @will-byrne-cardano,

Good catch on the urllib3 package, this is defiantly not a hard requirement, and we can get this removed.

In regards to the AWS Auth, are you proposing that we release a new package entirely?
I would be leaning towards keeping all the SDK fully functional as-is. Which package requirement(s) are limiting you? Perhaps we can allow for a wider range of versions instead.

@DanielHougaard DanielHougaard self-assigned this Feb 3, 2025
@will-byrne-cardano
Copy link
Author

In regards to the AWS Auth, are you proposing that we release a new package entirely?

No, I was thinking something along the lines of package extras so a statement like

pip install infisicalsdk 

would install the package core functionality (say, only relies on requests). Then a statement like:

pip install infisicalsdk[aws]

would install the extras like botocore that are required for AWS auth. Appreciate this might not be a route you want to go down though given it would introduce a breaking change

https://packaging.python.org/en/latest/specifications/dependency-specifiers/#extras
https://packaging.python.org/en/latest/specifications/pyproject-toml/#dependencies-optional-dependencies

Which package requirement(s) are limiting you?

Just urllib3, thanks for the response and confirming it's not a hard req

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants