Skip to content

Commit 65a5e6d

Browse files
Ryan Nystromfacebook-github-bot
authored andcommitted
Fix binding SC deselection crash and publish 3.1.1
Summary: - Fixed #918 by checking `respondsToSelector:` (boo optionals) - Cut 3.1.1 for immediate publish - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes #921 Differential Revision: D5748009 Pulled By: rnystrom fbshipit-source-id: b387b3988abc785f312bc47ac003851283972d7a
1 parent 0ad49e1 commit 65a5e6d

File tree

67 files changed

+161
-89
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

67 files changed

+161
-89
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,13 @@
22

33
The changelog for `IGListKit`. Also see the [releases](https://github.com/instagram/IGListKit/releases) on GitHub.
44

5+
3.1.1
6+
-----
7+
8+
### Fixes
9+
10+
- Prevent a crash when `IGListBindingSectionControllerDelegate` objects do not implement the optional deselection API. [Ryan Nystrom](https://github.com/rnystrom) [(#921)](https://github.com/Instagram/IGListKit/pull/921)
11+
512
3.1.0
613
-----
714

Examples/Examples-iOS/Podfile.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
PODS:
2-
- IGListKit (3.1.0):
3-
- IGListKit/Default (= 3.1.0)
4-
- IGListKit/Default (3.1.0):
2+
- IGListKit (3.1.1):
3+
- IGListKit/Default (= 3.1.1)
4+
- IGListKit/Default (3.1.1):
55
- IGListKit/Diffing
6-
- IGListKit/Diffing (3.1.0)
6+
- IGListKit/Diffing (3.1.1)
77

88
DEPENDENCIES:
99
- IGListKit (from `../../IGListKit.podspec`)
@@ -13,7 +13,7 @@ EXTERNAL SOURCES:
1313
:path: ../../IGListKit.podspec
1414

1515
SPEC CHECKSUMS:
16-
IGListKit: 5065cb595903016ca42ed52fc0f9cd3b13170bff
16+
IGListKit: cb97f405ae43e59fe1da74271e19427ec20d3c07
1717

1818
PODFILE CHECKSUM: 0d505f6895c1f8c0016d78680f9b532c444cbb5e
1919

Examples/Examples-iOS/Pods/Local Podspecs/IGListKit.podspec.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Examples/Examples-iOS/Pods/Manifest.lock

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Examples/Examples-iOS/Pods/Target Support Files/IGListKit/Info.plist

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Examples/Examples-macOS/Podfile.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
PODS:
2-
- IGListKit (3.1.0):
3-
- IGListKit/Default (= 3.1.0)
4-
- IGListKit/Default (3.1.0):
2+
- IGListKit (3.1.1):
3+
- IGListKit/Default (= 3.1.1)
4+
- IGListKit/Default (3.1.1):
55
- IGListKit/Diffing
6-
- IGListKit/Diffing (3.1.0)
6+
- IGListKit/Diffing (3.1.1)
77

88
DEPENDENCIES:
99
- IGListKit (from `../../IGListKit.podspec`)
@@ -13,7 +13,7 @@ EXTERNAL SOURCES:
1313
:path: ../../IGListKit.podspec
1414

1515
SPEC CHECKSUMS:
16-
IGListKit: 5065cb595903016ca42ed52fc0f9cd3b13170bff
16+
IGListKit: cb97f405ae43e59fe1da74271e19427ec20d3c07
1717

1818
PODFILE CHECKSUM: bbe5708b3a7f2dd7c70bb14225a7e37f67e1de58
1919

Examples/Examples-macOS/Pods/Local Podspecs/IGListKit.podspec.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Examples/Examples-macOS/Pods/Manifest.lock

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Examples/Examples-macOS/Pods/Target Support Files/IGListKit/Info.plist

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Examples/Examples-tvOS/Podfile.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
PODS:
2-
- IGListKit (3.1.0):
3-
- IGListKit/Default (= 3.1.0)
4-
- IGListKit/Default (3.1.0):
2+
- IGListKit (3.1.1):
3+
- IGListKit/Default (= 3.1.1)
4+
- IGListKit/Default (3.1.1):
55
- IGListKit/Diffing
6-
- IGListKit/Diffing (3.1.0)
6+
- IGListKit/Diffing (3.1.1)
77

88
DEPENDENCIES:
99
- IGListKit (from `../../IGListKit.podspec`)
@@ -13,7 +13,7 @@ EXTERNAL SOURCES:
1313
:path: ../../IGListKit.podspec
1414

1515
SPEC CHECKSUMS:
16-
IGListKit: 5065cb595903016ca42ed52fc0f9cd3b13170bff
16+
IGListKit: cb97f405ae43e59fe1da74271e19427ec20d3c07
1717

1818
PODFILE CHECKSUM: f68cec0d93efa38d42ede50dfe01309d83664d56
1919

0 commit comments

Comments
 (0)