Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update clang-format version #1892

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

update clang-format version #1892

wants to merge 1 commit into from

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jun 21, 2024

The PR proposes to update clang-format version.

There is a hard dependency to run the check with clang-format-15, since it is the latest version available for Ubuntu 22.04 (at the moment, ubuntu_latest is Ubuntu 22.04).
Need to note that different versions of clang-format might be incompatible with each other and so format C++ code differently.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Jun 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/1892/index.html

@vtavana vtavana marked this pull request as ready for review June 22, 2024 01:58
@vtavana vtavana marked this pull request as draft July 9, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov will be requested when the pull request is marked ready for review AlexanderKalistratov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vtavana