-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] fix initialization of ref_llm for full param dpo training with zero-3 #778
Conversation
Thank you for your contribution! It appears that this fix might not fully address the issue when using var_len_attention. I noticed another solution in PR #781, which seems to be a more comprehensive approach. |
@RangiLyu I checked the PR you mentioned above. However it's not a good idea to create another |
@xu-song Great PR! There are conflicts that need to be resolved. |
conflicts have been resolved |
ref_llm
can not be instantiated while full param dpo training with zero-3.This pull request enable instantiation of ref_llm with the following config.