phantom assert

Author: crocodile-dentist

ouroboros-network-framework/sim-tests/Test/Ouroboros/Network/Server/Sim.hs

@@ -1896,12 +1896,16 @@ prop_connection_manager_pruning (Fixed rnd) serverAcc
              -> Maybe (Either (WithName (Name SimAddr) (AbstractTransitionTrace SimAddr))
                               (WithName (Name SimAddr) (CM.Trace SimAddr
                                                           (ConnectionHandlerTrace UnversionedProtocol DataFlowProtocolData))))
-          fn _ (EventLog dyn) = Left  <$> fromDynamic dyn
-                            <|> Right <$> fromDynamic dyn
+          fn _ (EventLog dyn) = fromDynamic dyn
           fn _ _              = Nothing
 
   in  tabulate "ConnectionEvents" (map showConnectionEvents events)
-    -- . counterexample (ppScript (MultiNodeScript events attenuationMap))
+    . counterexample (ppScript (MultiNodeScript events attenuationMap))
+    . counterexample (concat
+        [ "\n\n====== Say Events ======\n"
+        , intercalate "\n" $ selectTraceEventsSay' trace
+        , "\n"
+        ])
     . mkPropertyPruning
     . bifoldMap
        ( \ case
@@ -1935,8 +1939,11 @@ prop_connection_manager_pruning (Fixed rnd) serverAcc
                tpActivityTypes       = [classifyActivityType       trs],
                tpTransitions         = trs
             }
-           Right b ->
-              mempty { tpNumberOfPrunings = classifyPruning b }
+           Right b
+             | CM.TrUnexpectedlyFalseAssertion assertionLoc <- b ->
+                 mempty { tpProperty = counterexample (show assertionLoc) False }
+             | otherwise ->
+                 mempty { tpNumberOfPrunings = classifyPruning b }
        )
     . fmap (first (map ttTransition))
     . groupConnsEither id abstractStateIsFinalTransition
@@ -2324,7 +2331,7 @@ multiNodeSim stdGen serverAcc dataFlow defaultBearerInfo
                    acceptedConnLimit events attenuationMap = do
   multiNodeSimTracer stdGen serverAcc dataFlow defaultBearerInfo acceptedConnLimit
                      events attenuationMap dynamicTracer dynamicTracer dynamicTracer
-                     (Tracer traceM) dynamicTracer debugTracerG
+                     (Tracer traceM) dynamicTracer dynamicTracer --debugTracerG
 
 
 -- | Connection terminated while negotiating it.

ouroboros-network-framework/src/Ouroboros/Network/ConnectionManager/Core.hs

@@ -10,7 +10,7 @@
 {-# LANGUAGE TupleSections            #-}
 {-# LANGUAGE UndecidableInstances     #-}
 
---{-# OPTIONS_GHC -fno-ignore-asserts #-}
+{-# OPTIONS_GHC -fno-ignore-asserts #-}
 -- | The implementation of connection manager.
 --
 -- The module should be imported qualified.
@@ -1210,8 +1210,9 @@ with args@Arguments {
                        , OperationSuccess KeepTr
                        , Nothing
                        )
-              OutboundDupState _connId _connThread _handle Expired ->
-                assert False $
+              OutboundDupState _connId _connThread _handle Expired -> do
+                void . throwIO . userError $ "0xdeadbeef"
+                -- assert False $
                 return ( Nothing
                        , Nothing
                        , OperationSuccess KeepTr