Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-no-tls not working #25

Open
liujunhui2 opened this issue Sep 22, 2022 · 2 comments
Open

-no-tls not working #25

liujunhui2 opened this issue Sep 22, 2022 · 2 comments

Comments

@liujunhui2
Copy link

./simple-tls -s -no-tls -ws -b :80 -d 127.0.0.1:22 -n example.com

client:
simple-tls -ws -b 127.0.0.1:2222 -d example.com:80 -n example.com

client output on connection:
failed to dial server connection: failed to WebSocket dial: failed to send handshake request: Get "https://example.com": x509: certificate signed by unknown authority

Conclusion: with -no-tls, server is still sending certificate

simple-tls v0.7.0-0-gdf0b4cc (go version: go1.17.6, os: linux, arch: amd64)
Linux Centos 7

@liujunhui2
Copy link
Author

./simple-tls -s -no-tls -ws -b :80 -d 127.0.0.1:22 -n example.com

client: simple-tls -ws -b 127.0.0.1:2222 -d example.com:80 -n example.com

client output on connection: failed to dial server connection: failed to WebSocket dial: failed to send handshake request: Get "https://example.com": x509: certificate signed by unknown authority

Conclusion: with -no-tls, server is still sending certificate

simple-tls v0.7.0-0-gdf0b4cc (go version: go1.17.6, os: linux, arch: amd64) Linux Centos 7

update:
Connection successful if client specify -no-verify

Conclusion: with -no-tls, server is still sending certificate

@liujunhui2
Copy link
Author

Update:
main.go:277, noTLS is not assigned

		server := core.Server{
			BindAddr:      bindAddr,
			DstAddr:       dstAddr,
			Websocket:     ws,
			WebsocketPath: wsPath,
			Cert:          cert,
			Key:           key,
			ServerName:    serverName,
			Auth:          auth,
			TFO:           tfo,
			IdleTimeout:   timeout,
		}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant